Arm backend: Remove test name convention and validation#18492
Merged
martinlsm merged 3 commits intopytorch:mainfrom Apr 8, 2026
Merged
Arm backend: Remove test name convention and validation#18492martinlsm merged 3 commits intopytorch:mainfrom
martinlsm merged 3 commits intopytorch:mainfrom
Conversation
It has been decided to remove test name convention because the benefit of it is not worth the maintenance cost. This patch removes test the validation script that was run by the pre-push hook. Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: I129db66db0d0c129313e41db4a719a77d74a8d96
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18492
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 3 Cancelled Jobs, 6 Unrelated FailuresAs of commit 1844d2d with merge base c11ba1b ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
Author
|
@pytorchbot label "partner: arm" |
pytorch-bot
Bot
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
Bot
added
the
release notes: none
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Arm backend’s test-name convention enforcement by deleting the supporting validation/parsing scripts and removing the corresponding pre-push hook check.
Changes:
- Delete the Python utilities used to collect tests and validate Arm test naming conventions.
- Remove the “Test name checks” block from the Arm
pre-pushscript so the validation no longer runs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backends/arm/scripts/testname_rules/validate_test_names.py | Removed the CLI entrypoint that applied naming rules to collected tests. |
| backends/arm/scripts/testname_rules/parse_test_names.py | Removed the name parsing/validation logic and violation reporting types. |
| backends/arm/scripts/testname_rules/collect_tests.py | Removed AST-based test discovery used by the validator. |
| backends/arm/scripts/testname_rules/collect_testname_resources.py | Removed generation of allowed targets/ops/models/passes used by name parsing. |
| backends/arm/scripts/pre-push | Removed invocation of the test-name validation from the pre-push checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zingo
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jpiat
pushed a commit
to jpiat/executorch
that referenced
this pull request
Apr 14, 2026
It has been decided to remove test name convention because the benefit of it is not worth the maintenance cost. This patch removes test the validation script that was run by the pre-push hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been decided to remove test name convention because the benefit of it is not worth the maintenance cost. This patch removes test the validation script that was run by the pre-push hook.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell